-
Notifications
You must be signed in to change notification settings - Fork 40
Adding GetVlanInterfaces method #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 @scshitole This must be merged before https://github.com/f5devcentral/terraform-provider-bigip/pull/126 !!! and vendoring updated afterwards. |
|
@dannyk81 thanks do you want to run the tests locally with this fix before committing ? |
|
Sure, let me run it now, will post results shortly. |
|
@scshitole test results below, I'm getting failures in a couple of But I haven't touched the code around this... maybe this is due to this commit --> hashicorp/terraform-provider-bigip@344b1fe ?? Here's the test result: |
|
@scshitole I reverted hashicorp/terraform-provider-bigip@344b1fe locally and now all tests pass: |
|
@dannyk81 which image you are using ? there is a change in the F5 code, with 13.0 image your fix should pass. |
|
@scshitole I use 12.1.1 |
|
@dannyk81 there was change in F5 code 13.0 so I have to change the test files for profiles |
|
@scshitole I see, but is this affecting only tests? or this will also have impact when provisioning these resource on a BigIP 12.1.1? In the README we claim that this suite was tested with 12.1.1, looks like this is no longer the case. |
|
@dannyk81 this is only test files rest is fine, I ran the tests with 13.0 after your fix |
New struct and method to retrieve a list of Interfaces associated to a named vlan.