-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias Command #1895
Alias Command #1895
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1895 +/- ##
=======================================
Coverage 95.68% 95.69%
=======================================
Files 126 126
Lines 10198 10213 +15
=======================================
+ Hits 9758 9773 +15
Misses 440 440 ☔ View full report in Codecov by Sentry. |
Is there anyway i can run stylecheck locally before pushing? |
of course, we use clang-format. single file:
all files:
Keep in mind different version of clang-format can provide different results. |
Co-authored-by: Mathieu Westphal <[email protected]>
Co-authored-by: Mathieu Westphal <[email protected]>
Thanks |
Co-authored-by: Mathieu Westphal <[email protected]>
please add documentation in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/comment changes cneeded
Co-authored-by: Mathieu Westphal <[email protected]>
what do you think about adding unalias command? |
Also, adding possibility to save created alias for later use, like alias in Bash |
That doesnt sounds necessary
You can store your alias in a command script and load it everytime, id say thats enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets small change
Thanks for your contribution @v0id-strike ! |
refactored: needed to open new branch. last one got ruined, yeap i had no idea what i was doing, just changed one line and choas started on my side