Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias Command #1895

Merged
merged 65 commits into from
Feb 24, 2025
Merged

Alias Command #1895

merged 65 commits into from
Feb 24, 2025

Conversation

v0id-strike
Copy link
Contributor

refactored: needed to open new branch. last one got ruined, yeap i had no idea what i was doing, just changed one line and choas started on my side

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (6fd0155) to head (51c7b60).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1895   +/-   ##
=======================================
  Coverage   95.68%   95.69%           
=======================================
  Files         126      126           
  Lines       10198    10213   +15     
=======================================
+ Hits         9758     9773   +15     
  Misses        440      440           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v0id-strike
Copy link
Contributor Author

Is there anyway i can run stylecheck locally before pushing?

@mwestphal
Copy link
Member

Is there anyway i can run stylecheck locally before pushing?

of course, we use clang-format.

single file:

clang-format -i /path/to/file

all files:

(shopt -s globstar; clang-format -i **/*.{h,cxx}

Keep in mind different version of clang-format can provide different results.

@v0id-strike
Copy link
Contributor Author

Thanks

@mwestphal
Copy link
Member

please add documentation in doc/users/COMMANDS.md

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/comment changes cneeded

@v0id-strike
Copy link
Contributor Author

v0id-strike commented Feb 22, 2025

what do you think about adding unalias command?

@v0id-strike
Copy link
Contributor Author

Also, adding possibility to save created alias for later use, like alias in Bash

@mwestphal
Copy link
Member

what do you think about adding unalias command?

That doesnt sounds necessary

Also, adding possibility to save created alias for later use, like alias in Bash

You can store your alias in a command script and load it everytime, id say thats enough.

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets small change

@mwestphal
Copy link
Member

Thanks for your contribution @v0id-strike !

@mwestphal mwestphal merged commit bb31af9 into f3d-app:master Feb 24, 2025
54 checks passed
@v0id-strike v0id-strike deleted the alias branch February 24, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants