-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change imgui style to match official F3D palette #1870
base: master
Are you sure you want to change the base?
Conversation
do you want to revive this one @Meakk ? |
Yes at some point, but feel free to take over if you want. |
8a77754
to
f6aea87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 148-149
- lines 198-198
@@ -133,7 +134,7 @@ with others. | |||
|
|||
The OFL allows the licensed fonts to be used, studied, modified and | |||
redistributed freely as long as they are not sold by themselves. The | |||
fonts, including any derivative works, can be bundled, embedded, | |||
fonts, including any derivative works, can be bundled, embedded, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fonts, including any derivative works, can be bundled, embedded, | |
fonts, including any derivative works, can be bundled, embedded, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwestphal should we exclude licenses from the checker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, you can add it to .prettierignore
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- vtkext/private/module/vtkF3DImguiConsole.cxx
- lines 157-158
- lines 207-207
@@ -133,7 +134,7 @@ with others. | |||
|
|||
The OFL allows the licensed fonts to be used, studied, modified and | |||
redistributed freely as long as they are not sold by themselves. The | |||
fonts, including any derivative works, can be bundled, embedded, | |||
fonts, including any derivative works, can be bundled, embedded, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fonts, including any derivative works, can be bundled, embedded, | |
fonts, including any derivative works, can be bundled, embedded, |
@mwestphal can you take a look at the new style and let me know what you think? I changed the font to the suggested mono-space font, and use the color from the F3D color set. |
Missing a file ? |
Remove your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks a bit strange with white bg. Should the box be dark in that case ?
Looks nice! I find the corner to be a bit too rounded, maybe a bit less ? The colors looks good. |
I agree about the rounding looking weird. That's also related to the aliasing issue @Ni-g-3l was experiencing. |
@Meakk do we target 3.1 ? |
If the split is on Sunday, I won't have time to finish it. It's not urgent anyway. 3.2 is fine. |
Partially fix: #1976