Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change imgui style to match official F3D palette #1870

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 3, 2025

Partially fix: #1976

@mwestphal
Copy link
Member

do you want to revive this one @Meakk ?

@Meakk
Copy link
Member Author

Meakk commented Feb 27, 2025

Yes at some point, but feel free to take over if you want.

@Meakk Meakk force-pushed the imgui-style branch 2 times, most recently from 8a77754 to f6aea87 Compare March 4, 2025 21:34
@Meakk Meakk changed the title [draft] Change imgui style to match official F3D palette Change imgui style to match official F3D palette Mar 4, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 148-149
    • lines 198-198

@@ -133,7 +134,7 @@ with others.

The OFL allows the licensed fonts to be used, studied, modified and
redistributed freely as long as they are not sold by themselves. The
fonts, including any derivative works, can be bundled, embedded,
fonts, including any derivative works, can be bundled, embedded,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fonts, including any derivative works, can be bundled, embedded,
fonts, including any derivative works, can be bundled, embedded,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwestphal should we exclude licenses from the checker?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, you can add it to .prettierignore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • vtkext/private/module/vtkF3DImguiConsole.cxx
    • lines 157-158
    • lines 207-207

@@ -133,7 +134,7 @@ with others.

The OFL allows the licensed fonts to be used, studied, modified and
redistributed freely as long as they are not sold by themselves. The
fonts, including any derivative works, can be bundled, embedded,
fonts, including any derivative works, can be bundled, embedded,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fonts, including any derivative works, can be bundled, embedded,
fonts, including any derivative works, can be bundled, embedded,

@Meakk
Copy link
Member Author

Meakk commented Mar 16, 2025

@mwestphal can you take a look at the new style and let me know what you think? I changed the font to the suggested mono-space font, and use the color from the F3D color set.
I've also added a border for better visibility of the UI when the viewport background color match the UI background color.

@mwestphal
Copy link
Member

@mwestphal can you take a look at the new style and let me know what you think? I changed the font to the suggested mono-space font, and use the color from the F3D color set. I've also added a border for better visibility of the UI when the viewport background color match the UI background color.

*** No rule to make target '/home/glow/dev/f3d/f3d/src/resources/Inter-Regular.ttf', needed by 'vtkext/private/module/F3DFontBuffer.h'.  Stop.

Missing a file ?

@Meakk
Copy link
Member Author

Meakk commented Mar 16, 2025

Missing a file ?

Remove your F3D_FONT_FILE entry in CMake

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a bit strange with white bg. Should the box be dark in that case ?

@mwestphal
Copy link
Member

Looks nice! I find the corner to be a bit too rounded, maybe a bit less ?

The colors looks good.

@Meakk
Copy link
Member Author

Meakk commented Mar 18, 2025

I agree about the rounding looking weird. That's also related to the aliasing issue @Ni-g-3l was experiencing.
I need to investigate more.

@mwestphal
Copy link
Member

@Meakk do we target 3.1 ?

@mwestphal mwestphal added this to the 3.1.0 milestone Mar 24, 2025
@Meakk
Copy link
Member Author

Meakk commented Mar 24, 2025

If the split is on Sunday, I won't have time to finish it. It's not urgent anyway. 3.2 is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework UI/UX using designer inputs
2 participants