-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli reader options #1860
base: master
Are you sure you want to change the base?
Cli reader options #1860
Conversation
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1860 +/- ##
==========================================
- Coverage 95.79% 95.76% -0.03%
==========================================
Files 128 128
Lines 10396 10398 +2
==========================================
- Hits 9959 9958 -1
- Misses 437 440 +3 ☔ View full report in Codecov by Sentry. |
Do you need any help or review to move forward @0xfedcafe ? |
Just that upper question about an optional and I’ll push hopefully the final commit for this task with the test |
Hi @0xfedcafe How is it going ? Do you need any help ? |
Hi @0xfedcafe Please do not hesitate to reach out if you need any guidance :) |
Hi @0xfedcafe ! Do you need a review or help with CI ? |
yes, i think a hint would be very helpful. i can't find why in some tests where the necessary plugins are loaded and the reader is not nullptr it still fails with "unsupported file format" |
fixes by mwestphal Co-authored-by: Mathieu Westphal <[email protected]>
There a small conflict to fix with master, let me know if you need help with that |
Hi @0xfedcafe Do you need help moving forward ? |
Added a CLI reader option #1735