Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PWA manifest #1731

Merged
merged 8 commits into from
Mar 10, 2025
Merged

add PWA manifest #1731

merged 8 commits into from
Mar 10, 2025

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Nov 25, 2024

A minimal effort attempt to make f3d.app/web a Progressive Web App in the hope that it would automagically make it "installable" and usable offline

@mwestphal
Copy link
Member

Is this still planned ?

@mwestphal
Copy link
Member

@Meakk @snoyer what is the status of this ?

@snoyer
Copy link
Contributor Author

snoyer commented Mar 1, 2025

It works locally (or at least it was working locally when I created the PR) but I don't know how we can test it online (GH pages on a fork don't include the web app) without testing it live (merge to master and deploy to f3d.app)

@mwestphal
Copy link
Member

(merge to master and deploy to f3d.app)

Fine by me, wdyt @Meakk ?

@Meakk
Copy link
Member

Meakk commented Mar 10, 2025

Let's merge it. I think there's a good change it will work when deployed.

@mwestphal
Copy link
Member

@snoyer looks like there is a small conflict to fix

@mwestphal mwestphal merged commit ad58bf5 into f3d-app:master Mar 10, 2025
54 checks passed
@snoyer snoyer deleted the pwa-poc branch March 11, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants