-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quake MDL feature #1591
Quake MDL feature #1591
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
+ Coverage 95.75% 95.84% +0.09%
==========================================
Files 125 127 +2
Lines 10572 10834 +262
==========================================
+ Hits 10123 10384 +261
- Misses 449 450 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @Youva !!
There is still some clean-up to do, especially memory leaks to fix, but they will appear in the CI when you will add a test.
90% of the job is done, and there's the annoying, yet important, finalization left :)
@Youva any news on this ? |
1 similar comment
@Youva any news on this ? |
Hi @Youva ! Looks like you are back. First you may want to rebase on the latest master :) |
You are modifying libf3d public API! |
Looks like your merge did not go as expected. I'd strongly suggest using rebase instead of merge. Let me know if I can help (on discord or here). |
70ec237
to
988186a
Compare
Hi @Youva Please resolve discussions you have adressed and let us know if this is ready for review. |
Also changed the config and added some tests.
4bee8b4
to
14613da
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hi @Youva , is this rdy for review ? |
Animations will often skip frames on windows, not sure why. |
Slow to read maybe ? |
Hi @Youva Can we metrge this and improve on it ? |
I think everything else is fine. |
Hi @Youva Looks like there are a few review item not adressed yet :) Let us know :) |
Alright, lets merge this, we will then improve on it iteratively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed, but we (maintainers) will take of them after this is merged.
Thanks for the contribution @Youva @malespiaut ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Youva Can you tell me where you found this file ?
I cannot find it in LibreQuake or anywhere else, did you create it from zombie.mdl yourself ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the file using hxd to cover some lines in the source code, it's basically a change in metadata so I think it's still LibreQuake's file.
I can make a basic mdl file if it's an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Its ok to do it like that, no need to do more :)
Adds class vtkQuakeMDLImporter that reads .MDL files.
The class :
Fix: #1310