Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF | KFAC] Use module names instead of data_ptr()s for mapping #79

Merged
merged 4 commits into from
Feb 17, 2024
Merged

[REF | KFAC] Use module names instead of data_ptr()s for mapping #79

merged 4 commits into from
Feb 17, 2024

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Feb 15, 2024 •
edited
Loading

Manually verified the GPU test works.

@f-dangel f-dangel requested review from runame and removed request for runame February 15, 2024 19:53
@f-dangel f-dangel requested a review from runame February 15, 2024 20:01
runame
runame approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is a nice refactor avoiding the previous issue.

@f-dangel f-dangel merged commit 73ee0eb into main Feb 17, 2024
7 checks passed
@f-dangel f-dangel deleted the ref-internal-mapping branch February 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-dangel @runame