Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Migrate from flake8, black, and isort to ruff #164

Merged
merged 15 commits into from
Jan 9, 2025
Merged

[CI] Migrate from flake8, black, and isort to ruff #164

merged 15 commits into from
Jan 9, 2025

Conversation

f-dangel
Copy link
Owner

Only review after #163.

@f-dangel f-dangel requested a review from runame December 31, 2024 20:26
@coveralls
Copy link

coveralls commented Jan 1, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12697461737

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.342%
Totals Coverage Status
Change from base Build 12680904155: 0.0%
Covered Lines: 1444
Relevant Lines: 1547
💛 - Coveralls

runame
runame reviewed Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also remove the isort dependency and add the corresponding ruff rules. Also, we could switch to theruff formatter as well, instead of using black.

makefile Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@f-dangel f-dangel requested a review from runame January 3, 2025 21:38
@f-dangel
Copy link
Owner Author

f-dangel commented Jan 3, 2025

Migrated formatting and import sorting.

I also tried using the docstring linter of ruff, but it produced too many errors that I don't have time to fix and incorporate in this PR. Might be a useful thing to add in the future though.

@f-dangel f-dangel changed the title [CI] Migrate from flake8 to ruff [CI] Migrate from flake8, black, and isort to ruff Jan 3, 2025
runame
runame approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

curvlinops/_torch_base.py Outdated Show resolved Hide resolved
curvlinops/diagonal/hutchinson.py Outdated Show resolved Hide resolved
curvlinops/fisher.py Outdated Show resolved Hide resolved
curvlinops/kfac.py Outdated Show resolved Hide resolved
curvlinops/kfac_utils.py Outdated Show resolved Hide resolved
curvlinops/trace/hutchinson.py Outdated Show resolved Hide resolved
docs/examples/basic_usage/example_benchmark.py Outdated Show resolved Hide resolved
docs/examples/basic_usage/example_inverses.py Outdated Show resolved Hide resolved
test/test_inverse.py Outdated Show resolved Hide resolved
test/utils.py Outdated Show resolved Hide resolved
@f-dangel f-dangel merged commit c49580a into main Jan 9, 2025
11 checks passed
@f-dangel f-dangel deleted the flake8-to-ruff branch January 9, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-dangel @coveralls @runame