Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] more test cases for inverse KFAC and fix bug in KFAC.load_state_dict #158

Merged
merged 6 commits into from
Dec 3, 2024
Merged

[ADD] more test cases for inverse KFAC and fix bug in KFAC.load_state_dict #158

merged 6 commits into from
Dec 3, 2024

Conversation

runame
Copy link
Collaborator

@runame runame commented Dec 1, 2024 •
edited
Loading

Follow up to #156, sorry, missed a test case.

Edit: Added even more test cases and discovered and fixed a bug in KFAC's load_state_dict function.

@runame runame added the enhancement New feature or request label Dec 1, 2024
@runame runame requested a review from f-dangel December 1, 2024 16:25
@runame runame self-assigned this Dec 1, 2024
@coveralls
Copy link

coveralls commented Dec 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12144048194

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 45 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.6%) to 89.43%
Files with Coverage Reduction New Missed Lines %
curvlinops/fisher.py 45 25.76%
Totals Coverage Status
Change from base Build 12098234071: -2.6%
Covered Lines: 1523
Relevant Lines: 1703
💛 - Coveralls

@runame runame changed the title [ADD] more test cases for inverse KFAC [ADD] more test cases for inverse KFAC and fix bug in KFAC.load_state_dict Dec 2, 2024
f-dangel
f-dangel reviewed Dec 3, 2024
View reviewed changes
curvlinops/kfac.py Show resolved Hide resolved
test/test_inverse.py Outdated Show resolved Hide resolved
@runame runame requested a review from f-dangel December 3, 2024 14:02
f-dangel
f-dangel approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@f-dangel f-dangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@f-dangel
Copy link
Owner

f-dangel commented Dec 3, 2024 •
edited
Loading

@runame Can you add an entry in the changelog, then merge?

@runame runame merged commit 188feab into main Dec 3, 2024
13 checks passed
@runame runame deleted the improve-tests branch December 3, 2024 17:57
@f-dangel f-dangel mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-dangel f-dangel f-dangel approved these changes

Assignees

@runame runame

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runame @coveralls @f-dangel