Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Change activation Hessian to purely PyTorch #157

Merged
merged 5 commits into from
Nov 30, 2024
Merged

[ADD] Change activation Hessian to purely PyTorch #157

merged 5 commits into from
Nov 30, 2024

Conversation

f-dangel
Copy link
Owner

No description provided.

@f-dangel f-dangel requested a review from runame November 29, 2024 22:18
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 12091118113

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 49 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-2.7%) to 89.384%
Files with Coverage Reduction New Missed Lines %
curvlinops/_base.py 2 81.56%
curvlinops/experimental/activation_hessian.py 2 97.47%
curvlinops/fisher.py 45 25.76%
Totals Coverage Status
Change from base Build 12089495841: -2.7%
Covered Lines: 1524
Relevant Lines: 1705
💛 - Coveralls

runame
runame approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@f-dangel f-dangel merged commit 5013fe7 into main Nov 30, 2024
13 checks passed
@f-dangel f-dangel deleted the activation-hessian-linop branch November 30, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Linear operators for PyTorch and SciPy
Development

Successfully merging this pull request may close these issues.
2 participants
@f-dangel @runame