Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI | FIX] Improve and run Fisher-MC tests on main #131

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Sep 23, 2024

I noticed that the Monte-Carlo tests were not running anymore because we switched from master to main.
This PR re-activates them, slightly refactors them to make them faster, and adapts their tolerances to account for cases we added but never tested.

@f-dangel f-dangel requested a review from runame September 23, 2024 15:03
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11000009874

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 88.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/examples/utils.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
curvlinops/examples/utils.py 1 31.25%
Totals Coverage Status
Change from base Build 10967050112: -0.2%
Covered Lines: 1346
Relevant Lines: 1516

💛 - Coveralls

@f-dangel f-dangel merged commit 8e47e57 into main Sep 23, 2024
13 checks passed
@f-dangel f-dangel deleted the fix-mc-tests branch September 23, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants