Skip to content

Conversation

ezyang
Copy link
Owner

@ezyang ezyang commented Apr 27, 2025

Stack from ghstack (oldest at bottom):

In the calls to run_formatter_without_commit for WriteFile, we need to be a bit more careful how we report the contents of the edited file back to the LLM. Specifically, we need to say what the file looks like POST-formatting.

f378d7e  (Base revision)
848e33b  Update run_formatter_without_commit to return post-formatting file contents
eb1e368  Update write_file to track post-formatting file contents
e76eefa  Update edit_file to track post-formatting file contents
f6bcb3b  Update edit_file to show post-formatting content in snippets
4335196  Update write_file to show post-formatting content snippets
e184154  Clarify that edit_file snippets show post-formatting content
0f41905  Import async_open_text for asynchronous file operations
HEAD     Use async_open_text instead of blocking open() for file reading

codemcp-id: 283-fix-improve-reporting-of-formatted-file-contents-t

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 27, 2025
In the calls to run_formatter_without_commit for WriteFile, we need to be a bit more careful how we report the contents of the edited file back to the LLM. Specifically, we need to say what the file looks like POST-formatting.

```git-revs
f378d7e  (Base revision)
848e33b  Update run_formatter_without_commit to return post-formatting file contents
eb1e368  Update write_file to track post-formatting file contents
e76eefa  Update edit_file to track post-formatting file contents
f6bcb3b  Update edit_file to show post-formatting content in snippets
4335196  Update write_file to show post-formatting content snippets
e184154  Clarify that edit_file snippets show post-formatting content
0f41905  Import async_open_text for asynchronous file operations
HEAD     Use async_open_text instead of blocking open() for file reading
```

codemcp-id: 283-fix-improve-reporting-of-formatted-file-contents-t
ghstack-source-id: 2b672ad
Pull-Request-resolved: #278
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 27, 2025
In the calls to run_formatter_without_commit for WriteFile, we need to be a bit more careful how we report the contents of the edited file back to the LLM. Specifically, we need to say what the file looks like POST-formatting.

```git-revs
f378d7e  (Base revision)
848e33b  Update run_formatter_without_commit to return post-formatting file contents
eb1e368  Update write_file to track post-formatting file contents
e76eefa  Update edit_file to track post-formatting file contents
f6bcb3b  Update edit_file to show post-formatting content in snippets
4335196  Update write_file to show post-formatting content snippets
e184154  Clarify that edit_file snippets show post-formatting content
0f41905  Import async_open_text for asynchronous file operations
ace7796  Use async_open_text instead of blocking open() for file reading
HEAD     Revert edit_file.py to use the original formatter implementation
```

codemcp-id: 283-fix-improve-reporting-of-formatted-file-contents-t
ghstack-source-id: 102163f
Pull-Request-resolved: #278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant