Skip to content

chore: typecheck git_message.py #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: typecheck git_message.py #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions codemcp/git_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ def update_commit_message_with_description(
message_after = main_message[end_marker_pos + len(END_MARKER) :]

# Parse the revision list
rev_entries = []
rev_entries: list[str] = []
if rev_list_content:
rev_entries = [
line.strip() for line in rev_list_content.splitlines() if line.strip()
]

# Process rev_entries: replace any HEAD entries with actual commit hash
has_base_revision = False
new_rev_entries = []
new_rev_entries: list[str] = []

for entry in rev_entries:
if "(Base revision)" in entry:
Expand Down Expand Up @@ -137,8 +137,8 @@ def update_commit_message_with_description(

if has_head_entry or has_base_revision:
# Old format detected, convert to new format with markers
new_rev_entries = []
filtered_lines = []
new_rev_entries: list[str] = []
filtered_lines: list[str] = []

for line in lines:
if "(Base revision)" in line or line.strip().startswith("HEAD"):
Expand Down Expand Up @@ -192,7 +192,7 @@ def update_commit_message_with_description(
else:
# No markers or HEAD entries, handle as normal
if description:
rev_entries = []
rev_entries: list[str] = []

# If we have a commit hash, initialize with base revision
if commit_hash:
Expand Down
Loading