Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 5.3, 5.5, 5.6 and 7.0 deprecation fixes #1428

Merged
merged 15 commits into from
Apr 29, 2019
Merged

PHP 5.3, 5.5, 5.6 and 7.0 deprecation fixes #1428

merged 15 commits into from
Apr 29, 2019

Conversation

vidarl
Copy link
Member

@vidarl vidarl commented Apr 2, 2019

Continuation of #1390

@gggeek
Copy link
Contributor

gggeek commented Apr 2, 2019

Good, but misses compatibility constructors for the ones which have been renamed to __construct

andrerom
andrerom suggested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides adding compat constructors, please remove commented out code

lib/ezfile/classes/ezgzipzlibcompressionhandler.php Outdated Show resolved Hide resolved
@vidarl vidarl mentioned this pull request Apr 2, 2019
Closed
1 task
@vidarl vidarl changed the title [WIP]PHP 5.3, 5.5, 5.6 and 7.0 deprecation fixes PHP 5.3, 5.5, 5.6 and 7.0 deprecation fixes Apr 2, 2019
@vidarl
Copy link
Member Author

vidarl commented Apr 2, 2019 •
edited
Loading

Good, but misses compatibility constructors for the ones which have been renamed to __construct

Fixed

@vidarl vidarl requested a review from andrerom April 2, 2019 12:41
@vidarl vidarl mentioned this pull request Apr 2, 2019
Closed
@andrerom andrerom added this to the 2019.03 milestone Apr 2, 2019
@vidarl vidarl force-pushed the php72-fixes_vl branch 2 times, most recently from 574fcbc to 6dbcc84 Compare April 3, 2019 09:34
@andrerom
Copy link
Contributor

From my side this is almost ready, only open topic is the one in lib/ezutils/classes/ezsendmailtransport.php which seems to indicate sender is set twice now in different ways.

andrerom
andrerom approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emodric / @glye / @gggeek ?

@andrerom andrerom merged commit 0711409 into master Apr 29, 2019
@andrerom andrerom deleted the php72-fixes_vl branch April 29, 2019 12:35
@pkamps pkamps mentioned this pull request May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggeek gggeek gggeek left review comments

@emodric emodric emodric approved these changes

@andrerom andrerom andrerom approved these changes

@glye glye glye approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
2019.03
Development

Successfully merging this pull request may close these issues.
6 participants
@vidarl @gggeek @andrerom @glye @emodric @pbek