EZP-20027: Provide possibility to filter children locations based on visibility #140
Conversation
… based on visibility
|
Shouldn't the default value depend on the setting of the siteaccess ie on a setting passed to the repository like it is done for the prioritized languages list ? |
|
Agreed with @dpobel. There should be an injected setting. Moreover, why is the filter deactivated by default ? |
If we inject it, then that means API is in charge of dealing with hidden content, always. This would mean a lot of changes to the API as this was not intended from the inception. So this PR is about making it possible for user code to deal with visibility, and to simplify things, provide a optional parameter to filter them out in this function since it does not provide access to specify query. |
|
that's a big loss for developers :-( that also means we have to update the code of the DemoBundle to force the fact we only want to load visible content otherwise the "hide/unhide" does not work out of the box... |
|
@dpobel Same feeling here. I think we can inject it and still be able to override by passing the value explicitly. |
If we pass setting to PAPI, it implies the logic is inside the API, while now it is outside the API, big difference. We can definitely discuss how we can handle this differently for 5.1 later, but right now this is about what we can / should do for 5.0. |
|
Given the DemoBundle issue is mostly fixed now*, we can maybe skip this PR and instead aim to find a better solution in 5.1 if needed. * reaming issue there is that it will show hidden menu locations if menu item has more locations and some of them are accessible. |
|
Closing PR, no feedback. |
No description provided.