Fix EZP-23644: add proper handling for hidden nodes in subtree fetches a... #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, @bdunogier I guess 5.4.0 / 5.4.1 and 5.3.4 |
|
review ping @yannickroger @bdunogier |
| @@ -180,6 +180,7 @@ public function buildSearch( $searchText, $params = array(), $searchTypes = arra | |||
| $params['Filter'] = array( $params['Filter'] ); | |||
| } | |||
|
|
|||
| $pathFieldName = $ignoreVisibility ? eZSolr::getMetaFieldName( 'path' ) : eZSolr::getMetaFieldName( 'visible_path' ) ; | |||
There was a problem hiding this comment.
Could be shortened a bit with
$pathFieldName = eZSolr::getMetaFieldName( $ignoreVisibility ? 'path' : 'visible_path );
|
+1 |
|
+1 Who's up to merge this ? |
…s and multiple locations
paulborgermans
force-pushed
the
EZP-23644
branch
from
1139658
to
adeb87c
Compare
andrerom
added a commit
that referenced
this pull request
Mar 23, 2015
Fix EZP-23644: add proper handling for hidden nodes in subtree fetches a...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nd multiple locations
Tested on 5.3 and 5.4
Link: https://jira.ez.no/browse/EZP-23644
TODO