Reset the session key for session attributes to a default Symfony value #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, on Symfony 3.4.39 (since symfony/symfony#36063), after logging into Netgen Admin UI, user is presented with an erroneous secondary login form, since now eZ Publish Legacy and Symfony use different session keys for session attribute storage, making the sessions incompatible:
After refreshing the page, everything works fine, but this fixes the issue completely by making sure that the sessions are compatible again after 3.4.39. It should also be fully backwards compatible with previous Symfony versions.
This could've maybe gone into Netgen Admin UI repo, but I feel this is a more generic fix and this is a more correct location for the fix.