Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove visibility change on global helper core service override. #175

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Remove visibility change on global helper core service override. #175

merged 2 commits into from
Dec 17, 2019

Conversation

xserna
Copy link
Contributor

@xserna xserna commented Dec 3, 2019

PR coming from #126 (comment)

@xserna xserna mentioned this pull request Dec 3, 2019
Merged
@andrerom andrerom requested a review from emodric December 3, 2019 12:31
@emodric
Copy link
Collaborator

emodric commented Dec 3, 2019

Can you use public: true to mark it specifically as public, instead of relying on the default Symfony behaviour (and to avoid the deprecation message)?

You can also leave a comment why it is needed to be public.

@andrerom
Copy link
Contributor

@emodric Maybe you can use suggest feature for what you had in mind?

@xserna xserna requested review from emodric and andrerom December 17, 2019 15:24
@andrerom andrerom merged commit d266caa into ezsystems:master Dec 17, 2019
@andrerom
Copy link
Contributor

Thanks @xserna 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emodric emodric emodric approved these changes

@andrerom andrerom Awaiting requested review from andrerom

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xserna @emodric @andrerom