Fix CORS OPTIONS Call for POST REST requests #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, should this be applied to 1.4 as well? (for eZ Platform 1.x) |
emodric
approved these changes
Jan 16, 2019
|
@SalvatorePollaci Up for rebasing, or do you prefer we do that for the merge? :) |
|
@andrerom honestly I would prefer that you guys rebase. Thanks 👍 |
|
ok |
andrerom
approved these changes
Jan 17, 2019
andrerom
pushed a commit
that referenced
this pull request
Jan 17, 2019
- Set RequestContext from Request in DefaultRouter
bdunogier
approved these changes
Jan 29, 2019
|
Fixed in ab86627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that all OPTIONS calls for POST REST requests return 405 error message, this is due to the fact that DefaultRouter uses Symfony's default RequestContext which refers to a GET request. Therefore I'm setting the the RequestContext given the Request Object.