Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split out a common typecheckFile func #344

Merged
merged 2 commits into from
Jun 20, 2022
Merged

refactor: split out a common typecheckFile func #344

merged 2 commits into from
Jun 20, 2022

Commits on Jun 4, 2022

  1. refactor: split out a common typecheckFile func 

    - this is used in 3 places and going to be more for the code I'm adding
  to fix type-only imports
  - so DRY it up and standardize the functionality too
    - some places had `noErrors = false` in one place while others had
      it in another
    - same for `printDiagnostics`
    - but the ordering actually doesn't matter, so just keep it
      consistent and the same
      - and then can split a common function that does both out

- technically, now getDiagnostics is _only_ used in typecheckFile, so
  I could link to the two together, but I'm refactoring that one up
  a little
  - but this a good, small example of how refactoring one part of a
    codebase can make it easier to identify more similar pieces and then
    refactor even more
    @agilgur5
    agilgur5 committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    4258895 View commit details
    Browse the repository at this point in the history

  2. fix lint error on shadowed name

    @agilgur5
    agilgur5 committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    8b5016b View commit details
    Browse the repository at this point in the history