Does not work with async plugins #105

vwxyutarooo · 2018-08-14T10:04:27Z

What happens and why it is wrong

This plugin does not work with plugin which containing async/await syntax caused by object-hash issue and tscache.ts. I think this is hard to fix object-hash because there is no way to detect asyncfunction now. So is there any alternative without object-hash?

Environment

Related
- Fix to work with rollup-plugin-typescript2 gregberge/svgr#147
- https://github.com/smooth-code/svgr/blob/master/packages/rollup/src/index.js#L11

Versions

typescript: 2.8.3
rollup: 2.1.1
rollup-plugin-typescript2: 0.14.0

rollup.config.js

import svgr from '@svgr/rollup';
import typescript from 'rollup-plugin-typescript2';

export default {
  // ...
  plugins: [
    replace({ 'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV) }),
    svgr(),
    typescript({
      useTsconfigDeclarationDir: true,
    })
  ],
  // ...
};

tsconfig.json

No relevant.

package.json

No relevant.

plugin output with verbosity 3

[!] (rpt2 plugin) Error: Unknown object type "asyncfunction"
src/components/atoms/Icon/index.ts
Error: Unknown object type "asyncfunction"
    at Object._object (/Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:218:17)
    at Object._function (/Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:319:14)
    at Object.dispatch (/Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:185:30)
    at /Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:246:18
    at Array.forEach (<anonymous>)
    at Object._object (/Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:242:21)
    at Object.dispatch (/Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:185:30)
    at /Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:260:23
    at Array.forEach (<anonymous>)
    at Object._array (/Users/vwxyutarooo/Projects/kouzoh/mercari-web-jp-component/node_modules/rollup-plugin-typescript2/node_modules/object-hash/index.js:259:20)

The text was updated successfully, but these errors were encountered:

ezolenko · 2018-08-14T17:03:45Z

I added a workaround to ignore anything object-hash can't process (see objecthash branch, objectHashIgnoreUnknownHack option). This can potentially make cache stale though, so not a good long term solution.

ezolenko · 2018-08-14T17:04:12Z

@wessberg

wessberg · 2018-08-14T17:39:16Z

I must admit I'm surprised this haven't been more of an issue so far since async functions are extremely common by now 😀. Which is also why I think that simply ignoring it will lead to a great deal of cache issues. The PR I submitted to object-hash some time ago was a consequence of this very issue, and I would suggest that you remove the dependency on object-hash. I'm pretty confident that the PR submitted some time ago would work just fine since it matches on the same value as provided in the error message and passed both unit tests and solved the issues in this plugin, so feel free to depend on the PR rather than the NPM package here.

@vwxyutarooo, an immediate workaround is to set clean: true in the config to bypass the cache completely. Alternatively (sorry for the plug) I built https://github.com/wessberg/rollup-plugin-ts which will also work just fine

ezolenko · 2018-08-14T19:21:50Z

@wessberg Yeah, I guess not many rollup plugins have async in their interface yet.

Do you know a better way of hashing objects? I need to create a cache key based partly on rollup configuration object (and therefore containing source of all the plugins used) that is passed in on startup.

ezolenko · 2018-08-14T19:23:32Z

btw, to clarify -- the problem applies to async stuff in rollup config itself. Async in the code being transpiled is not a problem, because code is hashed based on source text.

wessberg · 2018-08-14T21:28:19Z

Hmm, well, you could apply sha1 to the result of JSON.stringify'ing the entire config with a custom replacer that maps plugins to their name property which I'm pretty sure is required.
For example, the following rollup config:

{
  // ...
  treeshake: true,
  plugins: [
    myPlugin1(),
    myPlugin2()
  ],
  // ...
}

Could be converted into the following JSON representation:

{
  "treeshake": true,
  "plugins": [
    "name-of-my-plugin-1",
    "name-of-my-plugin-2"
  ]
}

And then you could apply sha1 and get a base64 string out or something like that which you could use as cache key?

ezolenko · 2018-08-15T16:25:29Z

I was thinking along those lines, but wouldn't that remove even more things from consideration for cache? I suspect object-hash was made specifically because JSON.stringify throws away anything that is not a plain value property, array or a dictionary -- there is nothing else in json spec.

ezolenko · 2018-08-15T16:29:09Z

I suppose I could incorporate a hash of package-lock,json and yarn equivalent, if there was a reliable way of finding them. (to mitigate effect of objectHashIgnoreUnknownHack option)

vwxyutarooo · 2018-08-16T02:20:17Z

Thanks guys discussing about this issue. Actually clean: true option dose not bypass the cache process so it's not working even a while. However, ignoreUnknown might possibly the way to fix this issue as @ezolenko say. I'll waiting 0.16.2 anyway!

wessberg · 2018-08-16T07:12:06Z

@vwxyutarooo, I was under the assumption that clean: true uses a noop cache strategy. That's what I remember that @ezolenko implemented some time ago. If it still attempts to compute a cache key from the rollup config, that behavior needs looking into in my opinion

vwxyutarooo · 2018-08-20T01:08:07Z

I don't know how this affected to object-hash result, However the objectHashIgnoreUnknownHack option on objecthash branch is works for me.

ezolenko · 2018-08-24T18:25:54Z

I reworked cache a bit so clean: true will not even invoke object-hash and merged everything into master. I'll release in a few days

ezolenko · 2018-08-28T17:36:01Z

In 0.17.0 now

brandon-leapyear · 2019-11-13T20:53:47Z

For another workaround not using the objectHashIgnoreUnknownHack hack, I ran into this problem using rollup-plugin-require-context, and the following snippet seems to work:

import requireContextORIGINAL from 'rollup-plugin-require-context'

const requireContext = (options) => {
  const plugin = requireContextORIGINAL(options)
  return {
    name: plugin.name,
    transform(code, id) {
      return plugin.transform(code, id)
    }
  }
}

Namely, making transform a normal function returning a promise.

…o rollup-plugin-typescript2 (#324) issue ezolenko/rollup-plugin-typescript2#105

agilgur5 · 2020-02-12T03:34:18Z

Thought I'd add an update for folks here that the root cause here was finally fixed in puleos/object-hash#90 (very similar to puleos/object-hash#68 referenced above) and here in #203. No need to use objectHashIgnoreUnknownHack to support async plugins and no more cache issues -- was just released as v0.26.0 🎉 😄

ezolenko/rollup-plugin-typescript2#105 (comment)

ezolenko added a commit that referenced this issue Aug 14, 2018

- object-hash hack optional #105

3b46e8d

ezolenko self-assigned this Aug 15, 2018

ezolenko added this to the 0.16.2 milestone Aug 15, 2018

vwxyutarooo mentioned this issue Aug 16, 2018

Fix to work with rollup-plugin-typescript2 gregberge/svgr#147

Merged

ezolenko closed this as completed Aug 28, 2018

joelgallant mentioned this issue Oct 18, 2018

Upgrades typescript plugin developit/microbundle#229

Closed

michaeltintiuc mentioned this issue Mar 22, 2019

Refactor ion-vue-router ionic-team/ionic-framework#17821

Merged

lazarljubenovic mentioned this issue Apr 10, 2019

Clash with rollup-plugin-typescript2? vladshcherbin/rollup-plugin-copy#16

Closed

christian-roy mentioned this issue Aug 21, 2019

Refactor: Utilisation de TypeScript kronostechnologies/design-elements#51

Merged

designorant mentioned this issue Sep 5, 2019

Extensible Rollup configuration jaredpalmer/tsdx#183

Merged

medelman17 mentioned this issue Sep 8, 2019

Migrate Rollup TS Plugin to '@wessberg/rollup-plugin-ts' to support async rollup plugins jaredpalmer/tsdx#200

Closed

DevanB mentioned this issue Nov 5, 2019

Support async rollup plugins / objectHashIgnoreUnknownHack flag from rpt2 jaredpalmer/tsdx#294

Closed

maxdavidson mentioned this issue Jan 4, 2020

Error: Unknown object type "asyncfunction" maxdavidson/rollup-plugin-sourcemaps#92

Closed

rockmandash mentioned this issue Jan 22, 2020

fix(tsconfig.json): transpile async await in order to be compatible to rollup-plugin-typescript2 vuejs/rollup-plugin-vue#324

Merged

znck pushed a commit to vuejs/rollup-plugin-vue that referenced this issue Jan 22, 2020

fix(tsconfig.json): transpile async await in order to be compatible t…

deb4a1b

…o rollup-plugin-typescript2 (#324) issue ezolenko/rollup-plugin-typescript2#105

slavafomin mentioned this issue Feb 4, 2020

Rollup fails when plugin's hook is defined using AsyncFunction rollup/rollup#3367

Closed

This was referenced Feb 5, 2020

Fix the crash when hashing an async function puleos/object-hash#90

Merged

(fix): upgrade object-hash to support async/await syntax #203

Merged

chocolateboy mentioned this issue Feb 16, 2020

Warning about using objectHashIgnoreUnknownHack in rollup-plugin-typescript2 egoist/bili#305

Closed

JoviDeCroock mentioned this issue Feb 18, 2020

Add Closure compiler developit/microbundle#569

Closed

lgarron added a commit to lgarron/clipboard-polyfill that referenced this issue Jun 25, 2020

Fx build with npm install rollup-plugin-typescript2@latest.

02d7356

ezolenko/rollup-plugin-typescript2#105 (comment)

KrzysztofMadejski mentioned this issue Jan 7, 2021

Error: Unknown object type "asyncfunction" in rollup-plugin-typescript2 apache/echarts#13974

Closed

darryltec mentioned this issue Apr 14, 2022

fix(design): Add back missing icon colors types GetJobber/atlantis#880

Merged

agilgur5 added kind: bug Something isn't working properly solution: workaround available There is a workaround available for this issue scope: upstream Issue in upstream dependency labels May 7, 2022

agilgur5 changed the title ~~Does not work with plugin which containing async/await syntax~~ Does not work with async plugins May 7, 2022

agilgur5 added scope: integration Related to an integration, not necessarily to core (but could influence core) scope: cache Related to the cache labels May 7, 2022

Repository owner locked as resolved and limited conversation to collaborators May 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Does not work with async plugins #105

Does not work with async plugins #105

vwxyutarooo commented Aug 14, 2018 •

edited by agilgur5

Loading

ezolenko commented Aug 14, 2018 •

edited

Loading

ezolenko commented Aug 14, 2018

wessberg commented Aug 14, 2018 •

edited

Loading

ezolenko commented Aug 14, 2018

ezolenko commented Aug 14, 2018

wessberg commented Aug 14, 2018 •

edited

Loading

ezolenko commented Aug 15, 2018

ezolenko commented Aug 15, 2018 •

edited

Loading

vwxyutarooo commented Aug 16, 2018

wessberg commented Aug 16, 2018

vwxyutarooo commented Aug 20, 2018

ezolenko commented Aug 24, 2018

ezolenko commented Aug 28, 2018 •

edited by agilgur5

Loading

brandon-leapyear commented Nov 13, 2019

agilgur5 commented Feb 12, 2020 •

edited

Loading

Does not work with async plugins #105

Does not work with async plugins #105

Comments

vwxyutarooo commented Aug 14, 2018 • edited by agilgur5 Loading

What happens and why it is wrong

Environment

Versions

rollup.config.js

tsconfig.json

package.json

plugin output with verbosity 3

ezolenko commented Aug 14, 2018 • edited Loading

ezolenko commented Aug 14, 2018

wessberg commented Aug 14, 2018 • edited Loading

ezolenko commented Aug 14, 2018

ezolenko commented Aug 14, 2018

wessberg commented Aug 14, 2018 • edited Loading

ezolenko commented Aug 15, 2018

ezolenko commented Aug 15, 2018 • edited Loading

vwxyutarooo commented Aug 16, 2018

wessberg commented Aug 16, 2018

vwxyutarooo commented Aug 20, 2018

ezolenko commented Aug 24, 2018

ezolenko commented Aug 28, 2018 • edited by agilgur5 Loading

brandon-leapyear commented Nov 13, 2019

agilgur5 commented Feb 12, 2020 • edited Loading

vwxyutarooo commented Aug 14, 2018 •

edited by agilgur5

Loading

ezolenko commented Aug 14, 2018 •

edited

Loading

wessberg commented Aug 14, 2018 •

edited

Loading

wessberg commented Aug 14, 2018 •

edited

Loading

ezolenko commented Aug 15, 2018 •

edited

Loading

ezolenko commented Aug 28, 2018 •

edited by agilgur5

Loading

agilgur5 commented Feb 12, 2020 •

edited

Loading