- fix for attempting to write declarations for virtual modules genera…

…ted by rollup-plugin-vue #97
ezolenko · Jul 9, 2018 · f0e466c · f0e466c
1 parent 9843cfb
commit f0e466c
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 12 deletions.
diff --git a/dist/index.d.ts.map b/dist/index.d.ts.map
diff --git a/dist/rollup-plugin-typescript2.cjs.js b/dist/rollup-plugin-typescript2.cjs.js
@@ -20179,9 +20179,15 @@ function typescript(options) {
                             const destDirectory = path.isAbsolute(destDirname) ? destDirname : path.join(process.cwd(), destDirname);
                             writeToPath = path.join(destDirectory, path.relative(process.cwd(), e.name));
                         }
-                        context.debug(() => `${safe_5("writing declarations")} for '${key}' to '${writeToPath}'`);
-                        // Write the declaration file to disk.
-                        tsModule.sys.writeFile(writeToPath, e.text, e.writeByteOrderMark);
+                        if (writeToPath.includes("?")) {
+                            // HACK for rollup-plugin-vue, it creates virtual modules in form 'file.vue?rollup-plugin-vue=script.d.ts'
+                            context.debug(() => `${safe_4("skipping declarations")} for '${key}', invalid file path`);
+                        }
+                        else {
+                            context.debug(() => `${safe_5("writing declarations")} for '${key}' to '${writeToPath}'`);
+                            // Write the declaration file to disk.
+                            tsModule.sys.writeFile(writeToPath, e.text, e.writeByteOrderMark);
+                        }
                     });
                 });
             }

diff --git a/dist/rollup-plugin-typescript2.cjs.js.map b/dist/rollup-plugin-typescript2.cjs.js.map
diff --git a/dist/rollup-plugin-typescript2.es.js b/dist/rollup-plugin-typescript2.es.js
@@ -20175,9 +20175,15 @@ function typescript(options) {
                             const destDirectory = isAbsolute(destDirname) ? destDirname : join(process.cwd(), destDirname);
                             writeToPath = join(destDirectory, relative(process.cwd(), e.name));
                         }
-                        context.debug(() => `${safe_5("writing declarations")} for '${key}' to '${writeToPath}'`);
-                        // Write the declaration file to disk.
-                        tsModule.sys.writeFile(writeToPath, e.text, e.writeByteOrderMark);
+                        if (writeToPath.includes("?")) {
+                            // HACK for rollup-plugin-vue, it creates virtual modules in form 'file.vue?rollup-plugin-vue=script.d.ts'
+                            context.debug(() => `${safe_4("skipping declarations")} for '${key}', invalid file path`);
+                        }
+                        else {
+                            context.debug(() => `${safe_5("writing declarations")} for '${key}' to '${writeToPath}'`);
+                            // Write the declaration file to disk.
+                            tsModule.sys.writeFile(writeToPath, e.text, e.writeByteOrderMark);
+                        }
                     });
                 });
             }

diff --git a/dist/rollup-plugin-typescript2.es.js.map b/dist/rollup-plugin-typescript2.es.js.map
diff --git a/src/index.ts b/src/index.ts
@@ -314,6 +314,7 @@ export default function typescript(options?: Partial<IOptions>)
 					{
 						if (!e)
 							return;
+
 						let writeToPath: string;
 						// If for some reason no 'dest' property exists or if 'useTsconfigDeclarationDir' is given in the plugin options,
 						// use the path provided by Typescript's LanguageService.
@@ -327,10 +328,18 @@ export default function typescript(options?: Partial<IOptions>)
 							writeToPath = join(destDirectory, relative(process.cwd(), e.name));
 						}
 
-						context.debug(() => `${blue("writing declarations")} for '${key}' to '${writeToPath}'`);
+						if (writeToPath.includes("?"))
+						{
+							// HACK for rollup-plugin-vue, it creates virtual modules in form 'file.vue?rollup-plugin-vue=script.d.ts'
+							context.debug(() => `${yellow("skipping declarations")} for '${key}', invalid file path`);
+						}
+						else
+						{
+							context.debug(() => `${blue("writing declarations")} for '${key}' to '${writeToPath}'`);
 
-						// Write the declaration file to disk.
-						tsModule.sys.writeFile(writeToPath, e.text, e.writeByteOrderMark);
+							// Write the declaration file to disk.
+							tsModule.sys.writeFile(writeToPath, e.text, e.writeByteOrderMark);
+						}
 					});
 				});
 			}