Fixes incorrect locale-based parsing in eddblink #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change was made to support non-English locale users with the eddblink date parsing functions, which relied upon locale-specific parsing. Unfortunately the submitted solution for that issue made further locale-specific assumptions that break in different ways. This change changes the system to instead parse the dates in a locale-agnostic manner. Tested by running the eddblink plugin on my system and seeing it was no longer broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change was made to support non-English locale users with the eddblink date parsing functions, which relied upon locale-specific parsing. Unfortunately the submitted solution for that issue made further locale-specific assumptions that break in different ways.
This change changes the system to instead parse the dates in a locale-agnostic manner.
Tested by running the eddblink plugin on my system and seeing it was no longer broken.
This change fixes #149