Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github actions to not try to publish when none on the main branch #134

Closed
eyeonus opened this issue Apr 26, 2024 · 1 comment
Closed

Fix github actions to not try to publish when none on the main branch #134

eyeonus opened this issue Apr 26, 2024 · 1 comment

Comments

@eyeonus
Copy link
Owner

eyeonus commented Apr 26, 2024

Not super important, just annoying.
kfsone added a commit to kfsone/Trade-Dangerous that referenced this issue Apr 29, 2024
@kfsone
fix: only try to publish from eyeonus repos
fd5c9ab 
fixes eyeonus#134

This makes the publish job dependent on being the eyeonus repository. It also moves the requirements files
into the top-level directory and organizes them into requirements, requirements-dev, and requirements-publish
which incrementally reference the previous requirements file to simplify them.

It's unusual for requirements*.txt to be in a subdirectory these days, and various tools are lazy about it,
which can make these chained-references problematic as some tools will intepret them relatively and some
won't; ergo having them in the tld together is less likely to suddenly not work one day.
@kfsone
Copy link
Contributor

kfsone commented Apr 29, 2024

You may also want to make it only publish for non-PR commits to release/v1, so you have chance to collect multiple PRs/do your own changes, before it goes ahead and publishes anything.

kfsone added a commit to kfsone/Trade-Dangerous that referenced this issue Apr 29, 2024
@kfsone
fix: only try to publish from eyeonus repos
993a1c7 
fixes eyeonus#134

This makes the publish job dependent on being the eyeonus repository. It also moves the requirements files
into the top-level directory and organizes them into requirements, requirements-dev, and requirements-publish
which incrementally reference the previous requirements file to simplify them.

It's unusual for requirements*.txt to be in a subdirectory these days, and various tools are lazy about it,
which can make these chained-references problematic as some tools will intepret them relatively and some
won't; ergo having them in the tld together is less likely to suddenly not work one day.
kfsone added a commit to kfsone/Trade-Dangerous that referenced this issue Apr 29, 2024
@kfsone
fix: only try to publish from eyeonus repos
4d136b8 
fixes eyeonus#134

This makes the publish job dependent on being the eyeonus repository. It also moves the requirements files
into the top-level directory and organizes them into requirements, requirements-dev, and requirements-publish
which incrementally reference the previous requirements file to simplify them.

It's unusual for requirements*.txt to be in a subdirectory these days, and various tools are lazy about it,
which can make these chained-references problematic as some tools will intepret them relatively and some
won't; ergo having them in the tld together is less likely to suddenly not work one day.
kfsone added a commit to kfsone/Trade-Dangerous that referenced this issue Apr 29, 2024
@kfsone
fix: only try to publish from eyeonus repos
da644b4 
fixes eyeonus#134

This makes the publish job dependent on being the eyeonus repository. It also moves the requirements files
into the top-level directory and organizes them into requirements, requirements-dev, and requirements-publish
which incrementally reference the previous requirements file to simplify them.

It's unusual for requirements*.txt to be in a subdirectory these days, and various tools are lazy about it,
which can make these chained-references problematic as some tools will intepret them relatively and some
won't; ergo having them in the tld together is less likely to suddenly not work one day.
kfsone added a commit to kfsone/Trade-Dangerous that referenced this issue Apr 29, 2024
@kfsone
fix: only try to publish from eyeonus repos
b4a8238 
fixes eyeonus#134

This makes the publish job dependent on being the eyeonus repository. It also moves the requirements files
into the top-level directory and organizes them into requirements, requirements-dev, and requirements-publish
which incrementally reference the previous requirements file to simplify them.

It's unusual for requirements*.txt to be in a subdirectory these days, and various tools are lazy about it,
which can make these chained-references problematic as some tools will intepret them relatively and some
won't; ergo having them in the tld together is less likely to suddenly not work one day.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfsone @eyeonus