Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed stroke attributes crash #640

Closed
vox-humana opened this issue Nov 25, 2019 · 1 comment
Closed

Malformed stroke attributes crash #640

vox-humana opened this issue Nov 25, 2019 · 1 comment
Milestone
0.9.7

Comments

@vox-humana
Copy link
Contributor

SVG Edit tool produces polygon with "null" values in stroke attributes by defaults.
Macaw expects some double value/values there and does force unwrap for string content which leads to crash.

svg-edit-polygon.svg.zip
@vox-humana vox-humana mentioned this issue Nov 25, 2019
Merged
ystrot added a commit that referenced this issue Nov 26, 2019
@ystrot
Merge pull request #641 from vox-humana/640-malformed-double-attribute
289c753 
#640 Remove force unwrap in `SVGParser.doubleFromString` method
@vox-humana
Copy link
Contributor Author

#641 was merged into master 🎉

explaineverything pushed a commit to explaineverything/Macaw that referenced this issue Mar 3, 2020
@lukaszkrystek
Merge branch 'master' into explain/release-1.0.4
fba472b 
* master: (79 commits)
  Update .gitignore
  Add Package.swift
  Revert "Fix exyte#623: Shape.bounds returns incorrect rectangle"
  Fix exyte#623: Shape.bounds returns incorrect rectangle
  exyte#640 Remove force unwrap in `SVGParser.doubleFromString` method
  Fix crash in parsing pattern
  Formatting issues fix
  Fix gradient stops parsing
  Lint formatting issues fixed
  Formatting fixes
  fix source files of projects, add to macos target
  Enable Catalyst support (fixes exyte#610)
  Fix links in readme
  Update README.md
  Added supported platform - macOS
  Restore method
  Replace test references
  Revert "Add print to tests"
  Trigger build
  Add print to tests
  ...

# Conflicts:
#	Source/render/GroupRenderer.swift
#	Source/svg/SVGParser.swift
#	Source/views/MacawView.swift
@ystrot ystrot added this to the 0.9.7 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.7
Development

No branches or pull requests
2 participants
@vox-humana @ystrot