refactor: modernize MulterError to ES6 class #1357
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,4 @@ | ||||||||
| const errorMessages = { | ||||||||
| LIMIT_PART_COUNT: 'Too many parts', | ||||||||
| LIMIT_FILE_SIZE: 'File too large', | ||||||||
| LIMIT_FILE_COUNT: 'Too many files', | ||||||||
|
|
@@ -11,14 +9,13 @@ var errorMessages = { | |||||||
| MISSING_FIELD_NAME: 'Field name missing' | ||||||||
| } | ||||||||
|
|
||||||||
| class MulterError extends Error { | ||||||||
| constructor (code, field) { | ||||||||
| super(errorMessages[code]) | ||||||||
|
There was a problem hiding this comment. The Error.captureStackTrace() call was removed but not replaced. In ES6 classes extending Error, you should call Error.captureStackTrace(this, MulterError) after super() to maintain proper stack trace behavior.
Suggested change
Member
Author
There was a problem hiding this comment. I ran a short test using the following script: // ORIGINAL IMPLEMENTATION
function MulterErrorOriginal(message) {
Error.captureStackTrace(this, this.constructor);
this.name = this.constructor.name;
this.message = message;
}
require('util').inherits(MulterErrorOriginal, Error);
// NEW ES6 CLASS IMPLEMENTATION (with Error.captureStackTrace)
class MulterErrorNew extends Error {
constructor(message) {
super(message);
this.name = this.constructor.name;
Error.captureStackTrace(this, MulterErrorNew);
}
}
// NEW ES6 CLASS IMPLEMENTATION (without Error.captureStackTrace)
class MulterErrorNewNoCapture extends Error {
constructor(message) {
super(message);
this.name = this.constructor.name;
}
}
function testErrorImplementation(ErrorClass, name) {
console.log(`\n${'='.repeat(50)}`);
console.log(`${name}`);
console.log(`${'='.repeat(50)}`);
// Basic properties test
const err = new ErrorClass('LIMIT_FILE_SIZE', 'avatar');
console.log('Properties:');
console.log(' name:', err.name);
console.log(' instanceof Error:', err instanceof Error);
console.log(' instanceof ErrorClass:', err instanceof ErrorClass);
try {
throw new ErrorClass('LIMIT_FILE_COUNT');
} catch (error) {
console.log(error.stack);
}
}
console.log('Node.js version:', process.version);
console.log('Comparing MulterError implementations...');
// Test all three implementations
testErrorImplementation(MulterErrorOriginal, 'ORIGINAL (function + util.inherits)');
testErrorImplementation(MulterErrorNew, 'NEW ES6 CLASS (with Error.captureStackTrace)');
testErrorImplementation(MulterErrorNewNoCapture, 'NEW ES6 CLASS (without Error.captureStackTrace)');As expected all outputs are the same so this comment is wrong: |
||||||||
| this.name = this.constructor.name | ||||||||
| this.code = code | ||||||||
| if (field) this.field = field | ||||||||
| } | ||||||||
| } | ||||||||
|
|
||||||||
| module.exports = MulterError | ||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not needed anymore as the stack trace is automatically captured by the constructors super call.