Skip to content

fix(sendStatus): prevent BigInt status codes #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(sendStatus): prevent BigInt status codes #6839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3f7514
fix(sendStatus): prevent BigInt status codes
Dhairya3391 Oct 12, 2025
d715914
fix(sendStatus): prevent invalid numeric status codes
Dhairya3391 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,11 @@ res.jsonp = function jsonp(obj) {
*/

res.sendStatus = function sendStatus(statusCode) {
// Prevent BigInt status codes from causing obscure errors
if (typeof statusCode === 'bigint') {
throw new TypeError('Status code must be an integer');
}

var body = statuses.message[statusCode] || String(statusCode)

this.status(statusCode);
Expand Down
13 changes: 13 additions & 0 deletions test/res.sendStatus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,18 @@ describe('res', function () {
.get('/')
.expect(500, /TypeError: Invalid status code/, done)
})

it('should raise error for BigInt(200) status code', function (done) {
var app = express();

app.use(function (req, res) {
res.sendStatus(BigInt(200));
});

request(app)
.get('/')
.expect(500)
.expect(/Status code must be an integer/, done);
});
})
})