Expanding the benchmark. #4880
Merged
Expanding the benchmark. #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
approved these changes
Apr 5, 2022
dougwilson
force-pushed
the
expand-benchmark
branch
from
1abc05b
to
3a9612e
Compare
dougwilson
force-pushed
the
expand-benchmark
branch
from
3a9612e
to
0b330ef
Compare
dougwilson
approved these changes
Apr 25, 2022
This was referenced Oct 27, 2024
This was referenced Oct 28, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request expands the existing benchmark to also check for varying connections, and to also show average latency (instead of just reqs/sec).
This is a simple change but I think it is important since the existing benchmark is 8 years old and is lacking in a lot of ways. In the future it can be further expanded or be completely rewritten to provide a better view of Express's performance.