Handling 204 status code in next(err).

[jsdevel]

No description provided.

[dougwilson]

204 is not an error code. next(err) is meant for errors only, which is >= 400.

[jsdevel]

@dougwilson makes sense. The existing code honors it though so perhaps it should be updated to barf on err.status < 400?

[dougwilson]

Ideally, but it's too late now until the next major. Also, I'm not sure what this is trying to accomplish, because Node.js core will automatically discard the body when you set the status to 204 (see https://github.com/joyent/node/blob/v0.10.29/lib/http.js#L1181-L1194 and https://github.com/joyent/node/blob/v0.10.29/lib/http.js#L844 and https://github.com/joyent/node/blob/v0.10.29/lib/http.js#L921).

[jsdevel]

@dougwilson strangely enough the response was never closed using request.js. It's probably worth further investigation to see if it's an issue in either node core or request.js.

[dougwilson]

strangely enough the response was never closed using request.js

I'm not sure what that means. When I applied your PR without the lib/application.js change, it still passed, so it doesn't seem like that test you added even relied on the change you made to the error handler.

[jsdevel]

Here you go @dougwilson pillarjs/finalhandler#1. Thanks for the direction!