Skip to content

Commit

Permalink
✨ bring back query tests for node 21 (#5690)
Browse files Browse the repository at this point in the history
  • Loading branch information
ctcpip authored Jun 5, 2024
1 parent 2803a2b commit 689073d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:

- name: Node.js 21.x
node-version: "21.6"

- name: Node.js 22.x
node-version: "22.0"

Expand All @@ -148,15 +148,6 @@ jobs:
nvm install --default ${{ matrix.node-version }}
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
- name: Configure npm
run: |
npm config set loglevel error
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi
- name: Install npm module(s) ${{ matrix.npm-i }}
run: npm install --save-dev ${{ matrix.npm-i }}
if: matrix.npm-i != ''
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
3 changes: 1 addition & 2 deletions test/support/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,11 @@ function getMajorVersion(versionString) {
}

function shouldSkipQuery(versionString) {
// Temporarily skipping this test on 21 and 22
// Temporarily skipping this test on 22
// update this implementation to run on those release lines on supported versions once they exist
// upstream tracking https://github.com/nodejs/node/pull/51719
// express tracking issue: https://github.com/expressjs/express/issues/5615
var majorsToSkip = {
"21": true,
"22": true
}
return majorsToSkip[getMajorVersion(versionString)]
Expand Down

0 comments on commit 689073d

Please sign in to comment.