Revert "Improve error message for null/undefined to res.status"

fixes #3968
expressjs · May 25, 2019 · 0a48e18 · 0a48e18
1 parent eed05a1
commit 0a48e18
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 36 deletions.
diff --git a/History.md b/History.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Revert "Improve error message for `null`/`undefined` to `res.status`"
+
 4.17.0 / 2019-05-16
 ===================
 

diff --git a/lib/response.js b/lib/response.js
@@ -64,10 +64,6 @@ var charsetRegExp = /;\s*charset\s*=/;
  */
 
 res.status = function status(code) {
-  if (code === undefined || code === null) {
-    throw new TypeError('code argument is required to res.status')
-  }
-
   this.statusCode = code;
   return this;
 };

diff --git a/test/res.status.js b/test/res.status.js
@@ -16,37 +16,5 @@ describe('res', function(){
       .expect('Created')
       .expect(201, done);
     })
-
-    describe('when code is undefined', function () {
-      it('should throw a TypeError', function (done) {
-        var app = express()
-
-        app.use(function (req, res) {
-          res.status(undefined).send('OK')
-        })
-
-        request(app)
-        .get('/')
-        .expect(500)
-        .expect(/TypeError: code argument is required to res.status/)
-        .end(done)
-      })
-    })
-
-    describe('when code is null', function () {
-      it('should throw a TypeError', function (done) {
-        var app = express()
-
-        app.use(function (req, res) {
-          res.status(null).send('OK')
-        })
-
-        request(app)
-        .get('/')
-        .expect(500)
-        .expect(/TypeError: code argument is required to res.status/)
-        .end(done)
-      })
-    })
   })
 })