Skip to content

Conversation

@wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Jan 23, 2025

Compare: https://github.com/expressjs/body-parser/compare/2.0.2..master

* deps:
  * type-is@^2.0.0
  * Removed destroy
* refactor: prefix built-in node module imports
* use the node require cache instead of custom caching

What's Changed

Full Changelog: master...2.1.0

@wesleytodd
Copy link
Member Author

For some reason it is not letting me add @Phillip9587 as a reviewer, so here is a ping.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually.. we need to change the HISTORY.md to include the release date, etc.

@wesleytodd
Copy link
Member Author

Fixed a second error I made while resolving the conflict in package.json. We had one commit that bumped all the ranges from ~ to ^ and also one to rev type-is and one to remove destroy. I took the wrong side of that merge conflict, both should be resolved now.

@wesleytodd
Copy link
Member Author

Oh, and I will update the history date if folks have reviewed the change set (thanks or the catch on the destroy dep @bjohansebas!) when we release.

@Phillip9587
Copy link
Member

LGTM

@Phillip9587
Copy link
Member

Can we please consider including #579?

@wesleytodd
Copy link
Member Author

@Phillip9587 merged that, and am going to publish this in the next hour or so if no one says otherwise.

@Phillip9587
Copy link
Member

@wesleytodd You forgot to change the header of the release in the HISTORY.md file.

@wesleytodd
Copy link
Member Author

I have not forgotten. I will update that as part of doing the release (otherwise if it sits longer again I just would have to bump it again).

@wesleytodd wesleytodd merged commit eedea54 into master Feb 10, 2025
11 checks passed
@wesleytodd
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants