add listener types #861
Merged
add listener types #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
approved these changes
Aug 30, 2023
EvanBacon
pushed a commit
to expo/expo
that referenced
this pull request
Aug 30, 2023
# Why Upstream expo/router#861 # Test Plan 
DavidAmyot
pushed a commit
to Villeco-inc/expo-router
that referenced
this pull request
Oct 16, 2024
# Why Upstream expo/router#861 # Test Plan 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FIX #860
Execution
The types were already exported from
@react-navigation, I usedwithLayoutContextwith generics to add those types inStack,TabsandDrawernavigationTest Plan
This pull request can be tested by checking the types of listener prop in any navigator in one of the sandbox projects in app directory