Skip to content

Fix codegen resolution error when node_modules has different version #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kudo merged 2 commits into from
Jan 20, 2022
Merged

Fix codegen resolution error when node_modules has different version #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd4504b
Fix codegen resolution error when node_modules has different version
Kudo Jan 17, 2022
73bca58
Fix another codegen resolution error from ios building
Kudo Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/generate-specs-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@

let RNCodegen;
try {
RNCodegen = require('react-native-codegen/lib/generators/RNCodegen.js');
// Use the `react-native-codegen` from the `react-native` repository instead of node_modules.
RNCodegen = require(__dirname + '/../packages/react-native-codegen/lib/generators/RNCodegen.js');
} catch (e) {
RNCodegen = require('../packages/react-native-codegen/lib/generators/RNCodegen.js');
if (!RNCodegen) {
Expand Down
3 changes: 2 additions & 1 deletion scripts/generate-specs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ main() {
exit 1
fi

CODEGEN_PATH=$("$NODE_BINARY" -e "console.log(require('path').dirname(require.resolve('react-native-codegen/package.json')))")
# Use the `react-native-codegen` from the `react-native` repository instead of node_modules.
CODEGEN_PATH="$RN_DIR/packages/react-native-codegen"

# Special case for running CodeGen from source: build it
if [ ! -d "$CODEGEN_PATH/lib" ]; then
Expand Down