[menu-bar] Reenable hermes (#209)

* [menu-bar] Reenable hermes * Add changelog entry
expo · Nov 4, 2024 · dda9b34 · dda9b34
1 parent 4c638a1
commit dda9b34
Show file tree

Hide file tree

Showing 5 changed files with 158 additions and 266 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,7 +16,7 @@
 
 - Update devices order to show physical devices first. ([#197](https://github.com/expo/orbit/pull/197) by [@gabrieldonadel](https://github.com/gabrieldonadel))
 - Improve listing connected Apple devices over Wi-Fi. ([#199](https://github.com/expo/orbit/pull/199) by [@gabrieldonadel](https://github.com/gabrieldonadel))
-- Upgrade `react-native` to 0.75.2. ([#203](https://github.com/expo/orbit/pull/203) by [@gabrieldonadel](https://github.com/gabrieldonadel))
+- Upgrade `react-native` to 0.75.2. ([#203](https://github.com/expo/orbit/pull/203), [#209](https://github.com/expo/orbit/pull/209), by [@gabrieldonadel](https://github.com/gabrieldonadel))
 - Upgrade to `expo` SDK 51. ([#204](https://github.com/expo/orbit/pull/204) by [@gabrieldonadel](https://github.com/gabrieldonadel))
 - Upgrade `react-native-svg` to 15.2.0. ([#204](https://github.com/expo/orbit/pull/204) by [@gabrieldonadel](https://github.com/gabrieldonadel))
 

diff --git a/apps/menu-bar/macos/ExpoMenuBar.xcodeproj/project.pbxproj b/apps/menu-bar/macos/ExpoMenuBar.xcodeproj/project.pbxproj
@@ -686,7 +686,7 @@
 				REACT_NATIVE_PATH = "${PODS_ROOT}/../../../../node_modules/react-native-macos";
 				SDKROOT = macosx;
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
-				USE_HERMES = false;
+				USE_HERMES = true;
 			};
 			name = Debug;
 		};
@@ -754,7 +754,7 @@
 				OTHER_LDFLAGS = "$(inherited)";
 				REACT_NATIVE_PATH = "${PODS_ROOT}/../../../../node_modules/react-native-macos";
 				SDKROOT = macosx;
-				USE_HERMES = false;
+				USE_HERMES = true;
 				VALIDATE_PRODUCT = YES;
 			};
 			name = Release;

diff --git a/apps/menu-bar/macos/Podfile b/apps/menu-bar/macos/Podfile
@@ -26,7 +26,7 @@ target 'ExpoMenuBar-macOS' do
   use_react_native!(
     :path => relative_rn_macos_path,
     # to enable hermes on macOS, change `false` to `true` and then install pods
-    :hermes_enabled => false
+    :hermes_enabled => true
   )
 
   # Pods specifically for macOS target