Shorten title length parameter #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2016 09:57
If not set, take the default shortenTitle fn
|
By analyzing the blame information on this pull request, we identified @ide, @jesseruder and @brentvatne to be potential reviewers |
|
Hi, Could you merge this request if everything's ok for you guys? Thanks, |
|
You should reimplement renderTitle in this case. We don't really want to expose niche configuration options like this. |
|
Then how do you solve this issue? You mean I need to use the renderNavigationBar method in order to have a custom navBar? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the issue #95 , I added a function parameter "shortenTitle".
In case it's not provided, it uses the default shortenTitle function there was in ExRouteRenderer component.
Cheers,