Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yarn usage instructions #342

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Fix Yarn usage instructions #342

merged 1 commit into from
Aug 4, 2017

Conversation

fson
Copy link
Contributor

@fson fson commented Aug 2, 2017

I fixed the yarnpkg alias usage in #329, but as a regression, the command is now written as yarnpkg in the usage instructions 😳

Success! Created my-crna-app at /Users/ville/Projects/my-crna-app
Inside that directory, you can run several commands:

  yarnpkg start
    Starts the development server so you can open your app in the Expo
    app on your phone.

  yarnpkg run ios
...

This PR changes the instructions back to yarn while keeping yarnpkg as the command that's actually invoked.

Test plan

Ran npm run build && npm pack in the react-scripts folder and created an app using CRNA:

create-react-native-app my-crna-app5 --scripts-version file:/path-to-react-native-scripts.tgz

Running ps in another terminal during installation displayed yarnpkg as the running process and instructions were displayed correctly in the end:
screen shot 2017-08-02 at 21 00 39

Print `yarn` in instructions instead of `yarnpkg`
@brentvatne brentvatne merged commit 676f034 into master Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants