Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kurdish Kurmanji language #13561

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Add Kurdish Kurmanji language #13561

merged 2 commits into from
Sep 9, 2024

Conversation

cikay
Copy link
Contributor

@cikay cikay commented Jul 8, 2024

Description

I could not find a document on how to add a new language. I just checked what the existing ones have and added them for Kurdish Kurmanji. I may miss things. Please let me know and also if there is you could provide a doc link for it.

Types of change

Adding a new language Kurdish Kurmanji

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all the required information.

@cikay
Copy link
Contributor Author

cikay commented Jul 8, 2024

Here is a universal dependency corpus https://github.com/UniversalDependencies/UD_Kurmanji-MG for Kurmanji

@cikay cikay force-pushed the kmr-initial branch 2 times, most recently from dde9a5b to 5c895d8 Compare July 9, 2024 17:28
@cikay
Copy link
Contributor Author

cikay commented Jul 28, 2024

https://spacy.io/usage/linguistic-features#language-data
Ok, I found it. Here, it is explained about language files and functions shortly.

@honnibal
Copy link
Member

honnibal commented Sep 9, 2024

Thanks! I haven't reviewed it carefully but it doesn't seem problematic to include it. I don't think I'll have time to add the models just now though.

@honnibal honnibal merged commit acbf2a4 into explosion:master Sep 9, 2024
@cikay cikay deleted the kmr-initial branch September 9, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants