-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doe jacobian remake #158
Doe jacobian remake #158
Conversation
Out of curiosity: What do you mean with the new nchoosek option does not seem to work nicely? What is happening if you use it? |
About the nchoosek constraints not working properly: I explained my findings here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
@dlinzner-bcs @DavidWalz : Do you also want to have a look, or should I just merge? |
I think, we should just merge it ;) |
This PR adds:
DOptimality
now contains both constraint evaluation and constraint jacobian evaluation.__call__()
andjacobian()
methods forNChooseKConstraint
using narrow Gaussians as discussed in DOE: NChooseK constraints #145 .