Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent modification #218

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

rdenarie
Copy link
Member

@rdenarie rdenarie commented Dec 4, 2023

No description provided.

Before this fix, sometimes, an entry in OO_EDITOR_CONFIG table is duplicated which lead to a problem when opening a document
This fix will ignore the additional entries, and keep only the first one
…h multiple users - EXO-67975

Before this fix, a race condition is possible when a lot of user edit the same document : even if a lock is set to the edited node when creating a new version, the lock allows the current lock owner to pass and then 2 thread (with the same user) can version the current node.
This lead to corrupt the node version history and lead to data loss

This commit enforce the lock so that it does not let the current lock owner to pass.
@rdenarie rdenarie requested review from ahamdi, mkrout and azayati December 4, 2023 17:01
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ahamdi ahamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdenarie Could you add a description for what was fixed by this PR with the related task ID?

@rdenarie
Copy link
Member Author

rdenarie commented Dec 5, 2023

As this PR have 2 commits for 2 differents tasks, task id are present in commit messages.
PR will be merge witt rebase (not squash), so commit message and ttask id will be kept

@rdenarie rdenarie enabled auto-merge (rebase) December 5, 2023 07:49
@rdenarie rdenarie merged commit 4a09b65 into feature/maintenance Dec 6, 2023
9 checks passed
@rdenarie rdenarie deleted the fix-concurrent-modification branch December 6, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants