Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An attempt to run tests on rust 1.41 #1394

Closed
wants to merge 2 commits into from
Closed

An attempt to run tests on rust 1.41 #1394

wants to merge 2 commits into from

Conversation

alekseysidorov
Copy link

No description provided.

@alekseysidorov alekseysidorov added wontfix work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! experimental ⚖️ Experimental PRs usually shall not be merged — they show some approach to get feedback from the team labels Jan 30, 2020
@coveralls
Copy link

coveralls commented Jan 30, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 84.928% when pulling 1710a3f on alekseysidorov:test_rust_1.41 into 3c1d023 on exonum:master.

@vitvakatu
Copy link
Contributor

vitvakatu commented Jan 30, 2020 •
edited
Loading

This configuration forces dynamic linkage of librocksdb:

⇒  otool -L target/debug/libjava_bindings.dylib
target/debug/libjava_bindings.dylib:
	@rpath/libjava_bindings.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libstd-861a2dddfff9db3f.dylib (compatibility version 0.0.0, current version 0.0.0)
	<....>
	/usr/local/opt/rocksdb/lib/librocksdb.6.5.dylib (compatibility version 0.0.0, current version 0.0.0)
	<....>

While possible, it requires to distribute dynamic rocksdb library somehow. Some considerations are collected in https://jira.bf.local/browse/ECR-3405

Static linkage does not work on both platforms, as rust-lang/rust#64340 is not fixed.

@vitvakatu
Copy link
Contributor

Judging by Travis history, this build is slower by 5-6 minutes by each job, i.e. 15-18 minutes for the whole build. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experimental ⚖️ Experimental PRs usually shall not be merged — they show some approach to get feedback from the team wontfix work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alekseysidorov @coveralls @vitvakatu @dmitry-timofeev