Update scalajs-js-envs to 1.4.0 #17
Conversation
This is needed to fix this issue scala-js/scala-js-js-envs#12 that is fixed in the latest version of `scalajs-env-nodejs` To share the version between build and meta-build I created a Scala file which I then syslinked to project/project/ by doing: ``` cd project/project ln -s ../MetaBuildShared.scala ```
| @@ -0,0 +1 @@ | |||
| ../MetaBuildShared.scala | |||
There was a problem hiding this comment.
Q) Why is this new file added?
It appears that scalajsJsEnvsVersion is not used in project/project/~.
There was a problem hiding this comment.
It is because project/project/*.scala files are available to project/*.sbt files as project/*.scala files are available to *.sbt files.
There was a problem hiding this comment.
I could also system-link it to project/MetaBuildShared.sbt which should be equivalent to project/project/MetaBuildShared.scala if you prefer.
There was a problem hiding this comment.
@exoego I can also skip this DRY attempt and have the version defined twice.
If you can, let me know what you prefer so we can merge this PR :)
There was a problem hiding this comment.
I still do not get it.
Again, it appears that scalajsJsEnvsVersion is not used in project/project/~.
I prefer not having unused file.
Is scalajsJsEnvsVersion used somewhere in project/project/~ ??
There was a problem hiding this comment.
project/project/*.scala files are compiled together with project/*.sbt so it is used in project/plugins.sbt.
It it's the same situation when you define a project/Build.scala, you might think that it is unused in project/~ but the values are used in root build.sbt
There was a problem hiding this comment.
If I delete project/project/MetaBuildShared.scala I get:
[info] welcome to sbt 1.5.3 (Homebrew Java 11.0.18)
/Users/lorenzo/scala/scala-js-env-jsdom-nodejs/project/plugins.sbt:6: error: not found: value MetaBuildShared
libraryDependencies += "org.scala-js" %% "scalajs-env-nodejs" % MetaBuildShared.scalajsJsEnvsVersion
^
[error] Type error in expression
This is needed to fix this issue scala-js/scala-js-js-envs#12 that is fixed in the latest version of
scalajs-env-nodejsTo share the version between build and meta-build I created a Scala file which I then syslinked to project/project/ by doing: