Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont' log missing Rails/Hanami unless DEBUG #217

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Dont' log missing Rails/Hanami unless DEBUG #217

merged 5 commits into from
Apr 17, 2024

Commits on Apr 17, 2024

  1. fix: warn when Hanami or Rails are not detected 

    I started noticing "Hanami not detected" lately.  I'm not sure exactly what to recommend here, perhaps only output anything when `ENV["CI"] == "true"` or something like that.. but I think preferring warn -> stderr over puts -> stdout is a good start to lower the shoutiness of it.
    @bf4
    bf4 authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0c2575c View commit details
    Browse the repository at this point in the history

  2. Hide these under flag

    @exoego
    exoego committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d40c398 View commit details
    Browse the repository at this point in the history

  3. Fix offense

    @exoego
    exoego committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a42ae91 View commit details
    Browse the repository at this point in the history

  4. minitest is needed :(

    @exoego
    exoego committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3834b8d View commit details
    Browse the repository at this point in the history

  5. revert

    @exoego
    exoego committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f2af288 View commit details
    Browse the repository at this point in the history