Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login issues 1.4.1 #718

Closed
chiefdan opened this issue Nov 29, 2018 · 12 comments
Closed

login issues 1.4.1 #718

chiefdan opened this issue Nov 29, 2018 · 12 comments
Assignees
Milestone

Comments

@chiefdan
Copy link

We are having a login issue where upon return from Eve SSO the character is selected and the user is returned to the character selection screen immediately.

The link is here:

https://[fqdn redacted]/sso/login?cookie=char_88732336c1309d6464fab1d3ae6b8623&tabId=n2j7q

We've cleared cookies client and server side and the issue persists. We are on version 1.4.1.

After waiting some time on the character select screen at some point the map may load.

My background is infrastructure so I'm not able to troubleshoot web very well, but if someone can assist to let me know which logs to maybe look at?

@Kaoraku
Copy link

Kaoraku commented Dec 9, 2018

We have the same issue, with 1.4.3

Also time to time got error 500 with the msg:

Internal Server Error

Fatal error: Module 'mbstring' already loaded

@dmullaney
Copy link

I have this problem too - 1.4.3

@chiefdan
Copy link
Author

We've updated to 1.4.3, switched to redis cache and rebuilt a new pathfinder db, the issue persists.

@MKUltraCorp
Copy link

Also having this problem on 1.4.3

@MKUltraCorp
Copy link

Any chance this will be looked at soon? Causing major issues here, it is so bad my guys are giving up on using Pathfinder.

@chiefdan
Copy link
Author

@TrinityErik I've noticed that I don't have the issue on my backup and dev servers, which are running on Ubuntu 18.04, only on the main which is on 16.04. I doubt the OS is responsible but it could be some of the default dependency versions. Looking to rebuild the main on 18.04 and see if it still occurs.

@MKUltraCorp
Copy link

Ok that is good info for us and the devs to have, thanks. I'm on 18.04 and having the issue so it isn't OS based. I'll have to check dependencies then because something has it all screwed up. Can you compare between your machines and maybe determine which ones could be at fault?

exodus4d added a commit that referenced this issue Dec 22, 2018
- improved error logging in case of failed login attempts
- improved ESI "access token" handling
@exodus4d
Copy link
Owner

It looks like this issue and the conversation here relates to totally different issues:

@Kaoraku Please check your php.ini file for duplicate entries of the mbstring module. This is a PHP config issue.

@TrinityErik I saw the same login issues 2 days ago. CCP has a devblog about the issue (https://developers.eveonline.com/blog/article/removal-of-redirect-from-.tech.ccp.is-on-jan-7th) the "old" ESI API URL changed, and they removed the ESI URL https://esi.tech.ccp.is (which is configured in your environment.ini) and replaced it with the new URL https://esi.evetech.net.
There is already an open PR for this which will be merged soon. But you should update the URL in your config, asap: fb48111

@chiefdan The next commit includes multiple improvements to the login sequence:

  • In case of login errors, users will get more detailed notification about the error type
  • In case of login errors, PHP logs more information about the issue into a new log file /log/character_access.log
  • ESI "access_token" handling is completely re-written. In case an "access_token" expires (max lifetime = 20min), a new token is requested from CCP 2min before the expire time of the old token reaches. In case of an error response for the new token (e.g. ESI timeouts,...) users will no longer get logged out. Pathfinder tries to request ESI for that new token as long as the old one is still valid (~2min). In case ESI failed all requests and the old token expires, users get logged out with message.

@exodus4d exodus4d added this to the v1.4.4 milestone Dec 22, 2018
@exodus4d exodus4d self-assigned this Dec 22, 2018
@MKUltraCorp
Copy link

Thanks, I had already made the changes to the environment.ini regarding the URL move but continued to have problems. Initial testing seems promising on the commit, I'll update if we see the same issues.

@exodus4d
Copy link
Owner

I was able to reproduce the login issue on my Server!

If you see issues where users click at their character image on login page and get redirected to login rather than /map view. You should try this hotfix:

Replace method checkLogTimer(): https://github.com/exodus4d/pathfinder/blob/master/app/main/controller/accesscontroller.php#L65

... with this:

private function checkLogTimer(\Base  $f3, Model\CharacterModel $character){
        $loginCheck = false;

        if(
            !$character->dry() &&
            $character->lastLogin
        ){
            // check logIn time
            $timezone = $f3->get('getTimeZone')();
            $maxLoginMinutes = (int)Config::getPathfinderData('timer.logged');

            $logoutTime  = new \DateTime($character->lastLogin, $timezone);
            $logoutTime->add(new \DateInterval('PT' . $maxLoginMinutes . 'M'));
            $now = new \DateTime('now', $timezone);

            if($logoutTime->getTimestamp() > $now->getTimestamp()){
                $loginCheck = true;
            }
        }

        return $loginCheck;
    }

@chiefdan
Copy link
Author

Tested and working for us, many thanks!

@Slivo-fr
Copy link

Any chance to get a minor release with the fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants