Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Multiple character location tracking #446

Open
Slivo-fr opened this issue Feb 20, 2017 · 14 comments
Open

[Feature] Multiple character location tracking #446

Slivo-fr opened this issue Feb 20, 2017 · 14 comments
Assignees

Comments

@Slivo-fr
Copy link

I'm switching from siggy where every associated character is tracked as the same time in the same tab.

I just realized pathfinder needs a tab per character. This is a terrible step back for us.
Please track every associated character when user is logged on !

@hilocz
Copy link

hilocz commented Feb 20, 2017

Silvio, that´s not terrible step back, that´s technology , which is possible. Go back to Siggy, if you aren´t happy with this tool.

@Slivo-fr
Copy link
Author

I'm not happy with Siggy, and I'm not saying this tool is bad.
I'm willing to help and contribute to make it better.

This feature is really something missing in my opinion !

@MorpheusXAUT
Copy link
Contributor

Whilst I agree that some way to track multiple characters within a single tab would be preferable, I disagree that pathfinder should track all characters associated with the account as soon as you log in one. Doing so could greatly increase pathfinder's load, often unnecessarily: I for instance have about 8 chars added in pathfinder, many of which I only use once every few months. Tracking all of them when I only log into my main would create a lot of unneeded API calls.

Instead, I propose a similar toggle like the map connection tracking one to be added to the character selection screen, allowing you to (manually) enable multiple characters to be tracked. I'm not entirely sure what backend changes that would require though.

@Slivo-fr
Copy link
Author

Slivo-fr commented Feb 21, 2017

Maybe only tracking online characters could reduce the load ?
Your toggle idea sounds fine to me, however this must be persistent over session so I only have to configure it once.

@MorpheusXAUT
Copy link
Contributor

MorpheusXAUT commented Feb 21, 2017

Figuring out if a character is online requires constant calls to the API as well unfortunately, actually the same location endpoint, so that wouldn't save much.

@hilocz
Copy link

hilocz commented Feb 21, 2017

PF evolved from not so friendly to multiple character tracking to current situation and I doubt, that it will change. IMHO nobody is happy to open multiple tabs, but if there were some possibility to get the tracking done i other way it would be already there.

@MorpheusXAUT
Copy link
Contributor

I guess it never hurts to check or talk to exodus on Slack about it to see if there is any other way.

If there really is none, I can deal with that as well since I just detach and minimize the tabs on a secondary screen anyways.

@hilocz
Copy link

hilocz commented Feb 21, 2017

@MorpheusXAUT if you have some ideas about changing way of character tracking, little brainstorming will definitely help.

@exodus4d exodus4d changed the title Multiple character location tracking [Feature] Multiple character location tracking Apr 12, 2017
@Slivo-fr
Copy link
Author

Slivo-fr commented Jun 4, 2017

Bump, I'm getting more issue with multiples tabs/char lately and still think loading all the page multiple time instead of tracking multiple chars on the same isn't a good thing.

This would be a major ergonomic improvement to me, and I think I'm not alone.

@acdoussan
Copy link

Man this is quite the dead thread. Would you guys consider a PR for this? If so if someone could point me to the section of code that currently syncs character location that would be great.

@exodus4d exodus4d self-assigned this Jul 5, 2019
exodus4d added a commit that referenced this issue Jul 5, 2019
- fixed a bug where "multi character location tracking" is not working on different browser tabs, #446
- fixed a "map sync" bug with 2 open browser tabs with the same character active
exodus4d added a commit that referenced this issue Jul 6, 2019
- fixed a "map sync" issue with multiple open tabs, #446
- fixed a bug where connections "disappear" from map for some seconds
- fixed a bug where "open ingame info" for char/system does not work in some UI tables
- upgraded [_Font Awesome_](https://fontawesome.com) icon lib `v5.2.0` → `v5.9.0`
@Markj2
Copy link

Markj2 commented Jul 11, 2019

This is the only thing holding my corp back from switching over fully to pathfinder, its hard to get everyone to open a tab for every character they have. This would be a huge improvement.

@acdoussan
Copy link

acdoussan commented Jul 13, 2019

Seems @exodus4d is fixing bugs with multiple tabs open. Hopefully some clean up before making it all work on one tab? Still willing to help out with some minor guidance to which part of the codebase currently handles this.

@exodus4d exodus4d mentioned this issue Jul 13, 2019
@Calavoow
Copy link

I think it would be great to have this feature. Perhaps you can add a switch for tracking a character to the character selection popup, instead of on the topright. This would relieve some load from the server to track by-default (since it'll be opt-in) but would still allow users to opt-in to tracking their active toons. Also it would allow folks to turn off tracking for toons they don't want to track any more.

@jacobmatthewjansen
Copy link

Whilst I agree that some way to track multiple characters within a single tab would be preferable, I disagree that pathfinder should track all characters associated with the account as soon as you log in one. Doing so could greatly increase pathfinder's load, often unnecessarily: I for instance have about 8 chars added in pathfinder, many of which I only use once every few months. Tracking all of them when I only log into my main would create a lot of unneeded API calls.

Instead, I propose a similar toggle like the map connection tracking one to be added to the character selection screen, allowing you to (manually) enable multiple characters to be tracked. I'm not entirely sure what backend changes that would require though.

This is probably the best “compromise” that would certainly limit load. This or some other way to toggle which characters are being tracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants