Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for duplicates before automatically adding new systems to the map #114

Closed
atkinsj opened this issue Mar 26, 2016 · 1 comment
Closed

Check for duplicates before automatically adding new systems to the map #114

atkinsj opened this issue Mar 26, 2016 · 1 comment
Assignees
@exodus4d
Labels
minor bug
Milestone
v 1.0.0

Comments

@atkinsj
Copy link

atkinsj commented Mar 26, 2016

At the moment you don't check for duplicates before calling system->save(), resulting in the error logs littered with "PDOStatement: Duplicate entry '25-31000717' for key 'system___mapId__systemId'".

api/system.php on line 238.
exodus4d added a commit that referenced this issue Apr 10, 2016
@exodus4d
closed #114 Added check for already existing system when adding a new…
3dc2f70 
… one. (fixed PDO 'duplicate entry' error)
@exodus4d
Copy link
Owner

Thanks for reporting! Should be fixed with the upcoming release

@exodus4d exodus4d added this to the v 1.0.0RC3 milestone Apr 10, 2016
@exodus4d exodus4d self-assigned this Apr 10, 2016
@exodus4d exodus4d mentioned this issue Apr 11, 2016
Closed
@exodus4d exodus4d mentioned this issue Jun 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exodus4d exodus4d

Labels
minor bug
Projects
None yet
Milestone
v 1.0.0
Development

No branches or pull requests
2 participants
@exodus4d @atkinsj