- improved "lazy delete" signatures toggle button. Now becomes "inact…

…ive" after each `ctrl`+`v` update action, closed #724
exodus4d · Jul 19, 2019 · 6ad71fd · 6ad71fd
1 parent 8c5385e
commit 6ad71fd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/js/app/ui/module/system_signature.js b/js/app/ui/module/system_signature.js
@@ -2355,8 +2355,7 @@ define([
 
         // "lazy update" toggle ---------------------------------------------------------------------------------------
         moduleElement.find('.' + config.moduleHeadlineIconLazyClass).on('click', function(e){
-            let button = $(this);
-            button.toggleClass('active');
+            $(this).toggleClass('active');
         });
 
         // set multi row select ---------------------------------------------------------------------------------------
@@ -2387,9 +2386,14 @@ define([
 
         // event listener for global "paste" signatures into the page -------------------------------------------------
         moduleElement.on('pf:updateSystemSignatureModuleByClipboard', {tableApi: primaryTableApi}, function(e, clipboard){
+            let lazyUpdateToggle = moduleElement.find('.' + config.moduleHeadlineIconLazyClass);
             let signatureOptions = {
-                deleteOld: moduleElement.find('.' + config.moduleHeadlineIconLazyClass).hasClass('active') ? 1 : 0
+                deleteOld: lazyUpdateToggle.hasClass('active') ? 1 : 0
             };
+
+            // "disable" lazy update icon -> prevents accidental removal for next paste #724
+            lazyUpdateToggle.toggleClass('active', false);
+
             updateSignatureTableByClipboard(e.data.tableApi, systemData, clipboard, signatureOptions);
         });
 

diff --git a/public/js/v1.5.2/app/ui/module/system_signature.js b/public/js/v1.5.2/app/ui/module/system_signature.js
@@ -2355,8 +2355,7 @@ define([
 
         // "lazy update" toggle ---------------------------------------------------------------------------------------
         moduleElement.find('.' + config.moduleHeadlineIconLazyClass).on('click', function(e){
-            let button = $(this);
-            button.toggleClass('active');
+            $(this).toggleClass('active');
         });
 
         // set multi row select ---------------------------------------------------------------------------------------
@@ -2387,9 +2386,14 @@ define([
 
         // event listener for global "paste" signatures into the page -------------------------------------------------
         moduleElement.on('pf:updateSystemSignatureModuleByClipboard', {tableApi: primaryTableApi}, function(e, clipboard){
+            let lazyUpdateToggle = moduleElement.find('.' + config.moduleHeadlineIconLazyClass);
             let signatureOptions = {
-                deleteOld: moduleElement.find('.' + config.moduleHeadlineIconLazyClass).hasClass('active') ? 1 : 0
+                deleteOld: lazyUpdateToggle.hasClass('active') ? 1 : 0
             };
+
+            // "disable" lazy update icon -> prevents accidental removal for next paste #724
+            lazyUpdateToggle.toggleClass('active', false);
+
             updateSignatureTableByClipboard(e.data.tableApi, systemData, clipboard, signatureOptions);
         });