Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the error message of invalid index expression use #696

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

rtzam
Copy link
Contributor

@rtzam rtzam commented Aug 23, 2024

This commit adds a test to verify that when a
user attempts to allocate a temporary
variable with an index type, a descriptive
error is provided

This commit adds a test to verify that when a
user attempst to allocate a temporary
variable with an index type, A descriptive
error is raised
@rtzam rtzam requested a review from yamaguchi1024 August 23, 2024 21:07
@yamaguchi1024
Copy link
Member

@rtzam lgtm, feel free to merge it!

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (b12ee6f) to head (2dc8105).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files          84       84           
  Lines       20716    20721    +5     
=======================================
+ Hits        18185    18190    +5     
  Misses       2531     2531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtzam rtzam merged commit 37dc108 into main Aug 28, 2024
10 of 11 checks passed
@rtzam rtzam deleted the improves-error-messaging-for-index-exprs branch August 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants