Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logical expressions containing True/False literals #609

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

SamirDroubi
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (773afdf) to head (c78e934).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   86.66%   86.67%   +0.01%     
==========================================
  Files          91       91              
  Lines       21362    21379      +17     
==========================================
+ Hits        18513    18530      +17     
  Misses       2849     2849              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@skeqiqevian skeqiqevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was the motivation for this change the ability to leverage if statement conditions in simplification?

@SamirDroubi
Copy link
Collaborator Author

LGTM. Was the motivation for this change the ability to leverage if statement conditions in simplification?

Sometimes you start with procedures with a lot of conditions and as you specialize it, those conditions become always true or false. The Gemini code here that got fixed is one example. It is generally nice if those true/false disappeared because they clobber the code and to allow other simplifications to happen (like what happened in the Gemini code for example).

@SamirDroubi SamirDroubi merged commit 2b1e7bc into main Mar 31, 2024
7 checks passed
@SamirDroubi SamirDroubi deleted the simplify-logical branch March 31, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants