Guard windows definitions with "include guards" #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We need to define exo window structs within the headers we generate because those definition depend on the kenrnel. * However, this means that including multiple headers generated by Exo can cause a compilation error because of duplicate definitions. * This commit wraps those definitions with "include guards" to avoid such conflicts.
|
This will break the BLAS codegen tests (the last step in the workflow), but we sure verify that it passes the build and correctness tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 86.66% 86.66%
=======================================
Files 91 91
Lines 21360 21362 +2
=======================================
+ Hits 18511 18513 +2
Misses 2849 2849 ☔ View full report in Codecov by Sentry. |
Actually, it turns out we don't test the headers codegen there so the tests didn't fail. |
yamaguchi1024
pushed a commit
that referenced
this pull request
Apr 24, 2024
* We need to define exo window structs within the headers we generate
because those definition depend on the kernel.
* However, this means that including multiple headers generated by Exo
can cause a compilation error because of duplicate definitions.
* This commit wraps those definitions with "include guards" to avoid
such conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because those definition depend on the kernel.
can cause a compilation error because of duplicate definitions.
such conflicts.